Cannot inject Tomcat DBCP 2 library in Gretty 3.1.0 via dependencies/gretty

[ahubmann]

Running into an issue upgrading from 3.0.9 to 3.1.0:

I'm injecting Tomcat/DBCP2 to look up database connections via JDNI as per documentation:
build.gradle

dependencies {
  gretty ("org.apache.tomcat:tomcat-dbcp:${project.tomcat9Version}")
}

This has stopped working in 3.1.0:

javax.naming.NamingException: Could not create resource factory instance
...
Caused by: java.lang.ClassNotFoundException: org.apache.tomcat.dbcp.dbcp2.BasicDataSourceFactory

I assume this is a side-effect of the class loader changes in 3.1.0? Any advice?

[f4lco]

Do you have a reproducer project? I have a hard time reproducing this error, because I hardly know tomcat-dbcp.

[f4lco]

Before that, could you try to put the dependency into configuration grettyRunnerTomcat9, rather than gretty, and report back if it works as expected?

[ahubmann]

Awesome, thanks for the swift reply and indeed, moving the dependency from gretty into the grettyRunnerTomcat9 configuration resolves the issue.

May I then suggest updating the two documentation links I posted above? In both instances, the documentation refers to the gretty configuration.

[dtbullock]

Same here. using gretty() in depencencies{} doesn't work, but using the (ahem, undocumented) grettRunnerTomcatX() does.

[jonfrench]

For users of jetty, I had to do this:

dependencies {
    grettyRunnerJetty10 'commons-dbcp:commons-dbcp:1.4'
}

gretty {
    servletContainer = 'jetty10'
}