Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclint_args causes quotation-explosion #8

Open
szepeviktor opened this issue Aug 11, 2022 · 3 comments
Open

eclint_args causes quotation-explosion #8

szepeviktor opened this issue Aug 11, 2022 · 3 comments

Comments

@szepeviktor
Copy link

      - name: "Check adherence to EditorConfig"
        uses: "greut/eclint-action@v0"
        with:
          eclint_args: "-exclude '{bin/generate.php,bin/shape.php}'"

Turns into eclint '-color=always' -exclude ''"'"'{bin/generate.php,bin/shape.php}'"'"

https://github.com/johnbillion/args/runs/7787549221?check_suite_focus=true

What could it be?

@szepeviktor szepeviktor changed the title eclint_Agrs causes quotation-explosion eclint_args causes quotation-explosion Aug 11, 2022
@szepeviktor
Copy link
Author

This works.

      - name: "Check adherence to EditorConfig"
        uses: "greut/eclint-action@v0"
        with:
          eclint_args: "-exclude {bin/generate.php,bin/shape.php}"

@szepeviktor
Copy link
Author

szepeviktor commented Sep 2, 2022

Just found out that using an equal sign makes GHA quote both the option name and its value.

      - name: "Check adherence to EditorConfig"
        uses: "greut/eclint-action@v0"
        with:
          eclint_args: |
            -exclude=dependencies/**/*

kép

@szepeviktor
Copy link
Author

Please consider using = in README's examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant