Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue GridapGmsh in Windows 10 #36

Closed
c-schubert opened this issue Feb 5, 2021 · 3 comments
Closed

Issue GridapGmsh in Windows 10 #36

c-schubert opened this issue Feb 5, 2021 · 3 comments

Comments

@c-schubert
Copy link
Contributor

Query of deps/build.jl line 20 and 21 does not work under Windows 10, even if the environment variable to the GMSH SDK is set correctly.

 gmsh_bin = joinpath(gmsh_root,"bin","gmsh")
  if isfile(gmsh_bin)

Fix is:

 gmsh_bin = joinpath(gmsh_root,"bin","gmsh.exe")
  if isfile(gmsh_bin)

Of course, a query of the target system should be made before ,so that at the same the functionality for Unix systems is not disturbed ...

@fverdugo
Copy link
Member

fverdugo commented Feb 5, 2021

Thanks for reporting! Perhaps we can check that either gmsh or gmesh.exe exists. Can you open a PR?

@c-schubert
Copy link
Contributor Author

c-schubert commented Feb 6, 2021

Done but found another issue, I do not know how to fix in a hurry ... , will open another issue in this #38 ...

@fverdugo
Copy link
Member

fverdugo commented Feb 7, 2021

Fixed in PR #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants