Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Validation of Variant Origin #437

Open
ahwagner opened this issue Jul 24, 2018 · 1 comment
Open

Check Validation of Variant Origin #437

ahwagner opened this issue Jul 24, 2018 · 1 comment
Labels
bug

Comments

@ahwagner
Copy link
Member

I ran across 3 evidence items lacking a variant origin designation. Somehow these got past our form validation. May be worth validating at both the client and server to prevent in the future.

EIDs 6223, 6393, 6332.
@ahwagner ahwagner added the bug label Jul 24, 2018
@susannasiebert
Copy link
Contributor

@ahwagner Do you think this should be implemented as a database constraint or via a validates_presence_of in the EI model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahwagner @susannasiebert