Attachment icon is missing

[georgegevoian]

Describe the current behavior

The recent upgrade to Bootstrap 5 appears to have broken the attachment icon in Grist. (See attached screenshot.)

CC @hexaltation

Steps to reproduce

No response

Describe the expected behavior

No response

Where have you encountered this bug?

• On docs.getgrist.com
• On a self-hosted instance

Instance information (when self-hosting only)

No response

[hexaltation]

Hello @georgegevoian,

As it is an atomic commit d036d28
it can be reversed easily.

I can take a look on monday if it's not fixed before.
And add a test to detect that attachment icon properly appears when it is needed.

[georgegevoian]

Hello @georgegevoian,

As it is an atomic commit d036d28 it can be reversed easily.

I can take a look on monday if it's not fixed before. And add a test to detect that attachment icon properly appears when it is needed.

Great, thanks @hexaltation!

[hexaltation]

Glyphicon support was removed from Bootstrap since version 4.

It's used in these files :

$ grep -rin glyphicon
client/lib/koForm.js:337:    this.optionButton("left", dom('span.glyphicon.glyphicon-align-left'),
client/lib/koForm.js:339:    this.optionButton("center", dom('span.glyphicon.glyphicon-align-center'),
client/lib/koForm.js:341:    this.optionButton("right", dom('span.glyphicon.glyphicon-align-right'),
client/lib/koForm.js:482:            dom('span.kf_drag_indicator.glyphicon.glyphicon-option-vertical') :
client/lib/koForm.js:487:            return dom('span.drag_delete.glyphicon.glyphicon-remove',
client/components/DocConfigTab.js:19:      dom('span.glyphicon.glyphicon-check'),
client/components/ValidationPanel.js:66:            dom('div.validation_trash.glyphicon.glyphicon-remove',
client/components/ValidationPanel.js:71:            1, dom('div.glyphicon.glyphicon-tag.config_icon'),
client/components/ColumnFilters.css:69:.g-glyphicon-tristate {
client/components/RecordLayoutEditor.js:128:    dom('div.g_record_delete_field.glyphicon.glyphicon-eye-close',
client/widgets/AttachmentsWidget.ts:193:const cssAttachmentIcon = styled('div.glyphicon.glyphicon-paperclip', `

Glyphicon have a pricing model that don't match an open source project (has every self hoster must buy a license).

Octicon seems to be a better solution as it's fee free and under MIT license.

[hexaltation]

Update
It seems that all icons used in glyphicons have an equivalent in static/icons/icons.css
So I will do a replacement with it rather than add a new dependency in Grist-core

[hexaltation]

@georgegevoian can you confirm my intuition that this two files are dead code.

client/components/DocConfigTab.js
client/components/ValidationPanel.js

ValidationPanel.js is only referenced in DocConfigTab.js

And DocConfigTab.js is only referenced for a unique autodispose in

grist-core/app/client/components/GristDoc.ts

Line 540 in 2f5ec0d

this.autoDispose(DocConfigTab.create({gristDoc: this}));

---

The same for

grist-core/app/client/lib/koForm.js

Line 335 in 2f5ec0d

exports.alignmentSelector = function(valueObservable) {

alignmentsSelector is never called

Do you feel comfortable with the idea that I remove this parts of code.
Or do you think I missed a thing?

[dsagal]

OK to remove. There used to be a whole "Validations" feature, but it wasn't polished, so was disabled from UI, and given many years that passed, I am comfortable dropping it entirely.