From 1ba51b7490d5c34a75983b5519820ba73ed9d323 Mon Sep 17 00:00:00 2001 From: Purnesh Dixit Date: Mon, 3 Feb 2025 09:36:37 +0530 Subject: [PATCH] internal/dns: update TestDNSResolver_ExponentialBackoff to not return error before last resolution attempt --- internal/resolver/dns/dns_resolver_test.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/internal/resolver/dns/dns_resolver_test.go b/internal/resolver/dns/dns_resolver_test.go index 47285052e622..fecd6e656e7b 100644 --- a/internal/resolver/dns/dns_resolver_test.go +++ b/internal/resolver/dns/dns_resolver_test.go @@ -626,13 +626,17 @@ func (s) TestDNSResolver_ExponentialBackoff(t *testing.T) { } } + if i == retries-1 { + // Update resolver.ClientConn to not return an error + // anymore before last resolution retry to ensure that + // last resolution attempt doesn't back off. + returnNilErr.Store(true) + } + // Unblock the DNS resolver's backoff by pushing the current time. timeChan <- time.Now() } - // Update resolver.ClientConn to not return an error anymore. - returnNilErr.Store(true) - // Unblock the DNS resolver's backoff, if ongoing, while we set the // test clientConn to not return an error anymore. select {