Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markor always starts on "Files" tab when launched via app's icon #2529

Open
4 tasks done
PetbkA opened this issue Feb 16, 2025 · 4 comments
Open
4 tasks done

Markor always starts on "Files" tab when launched via app's icon #2529

PetbkA opened this issue Feb 16, 2025 · 4 comments

Comments

@PetbkA
Copy link

PetbkA commented Feb 16, 2025

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Usually when you're opening some file in some editor → Hide this editor via Home/"circle" navbar button and then launch editor via it's icon on launcher, editor opens up where it was before hiding.

Markor always opens Files tab which is very annoying 'cause you have to:

  1. Either go to file in Files tab again;
  2. Or use Recent Apps/"square" navbar button. In cases when some other apps have been opened while Markor was hidden you have to find it's card there.

Should note that Markor ignores the App start tab setting too, i.e. it'll start in Files even if QuickNote has been set there.

The problem occurs even if Multiple windows is disabled (when enabled, such behavior is pretty logical)

Steps to reproduce

  1. Disable Multiple windows mode;
  2. From Files tab open some file for editing;
  3. Hide Editor via Home/"circle" navbar button;
  4. Run Markor via launcher - NOK: instead of file from step 3 Markor starts on Files tab

Information

Android version: 13 (crDroid 9.14)
Device: Xiaomi Redmi Note 12 Turbo 12/512
App Version:

  1. Markor: 2.14.0
  2. Marder: 2.14.0-1820

Source

GitHub Releases

Format / File type

Not specific

Additional info / Log

-
@PetbkA PetbkA changed the title Can't return to already opened file via launcher Markor always starts on "Files" tab when launched via app's icon Feb 16, 2025
@gsantner
Copy link
Owner

gsantner commented Feb 16, 2025

Setting todo/quicknote as start tab opens them up here when starting Markor.

Otherwise, main window and each file has own window.

Disabling separate windows might not properly work currently, thats known.

@harshad1
Copy link
Collaborator

Interesting. I can reproduce this. Will investigate if there is a way to not do this.

@harshad1
Copy link
Collaborator

I think the correct behaviour is to bring the MainActivity to the front but allow the user to dismiss it with 'back'. Right now back exits the app instead.

@harshad1
Copy link
Collaborator

I have a solution to this.

  • Fixes going back from file explorer to file
  • Fixes launcher icon -> open file
  • Generally makes the behaviour more like other apps

However, it involves changing the launch mode of MainActivity to singleTop. This can mean that more than 1 instance of MainActivity can potentially exist. This doesn't seem to cause any issues but iirc is something we have avoided in the past.

@gsantner any opinions in this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants