Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BoG S24] Finalize New Time Picker #269

Open
yatharth-b opened this issue Jan 22, 2024 · 0 comments
Open

[BoG S24] Finalize New Time Picker #269

yatharth-b opened this issue Jan 22, 2024 · 0 comments
Assignees
@iphonecats
Labels
task Task issue for a current or past sprint

Comments

@yatharth-b
Copy link
Contributor

yatharth-b commented Jan 22, 2024 •
edited
Loading

Problem Description

We have a time picker for custom events from S23, we would like to refactor it slightly to improve readability and code quality.

Your Goal

  • look at the old code in Nathan's PR here - New Time Picker Component for Recurring Events #240
  • Refactor it and improve code quality (state, useEffect, CSS) as you see fit. Some ideas - redundant state, unncessary useEffect
  • If time permits look over how gt-scheduler loads data. Start reading at components/AppDataLoader.
@yatharth-b yatharth-b added the task Task issue for a current or past sprint label Jan 22, 2024
@iphonecats iphonecats self-assigned this Jan 30, 2024
@iphonecats iphonecats mentioned this issue Jan 30, 2024
Merged
3 tasks
yatharth-b pushed a commit that referenced this issue Feb 4, 2024
@iphonecats
Finalize new time picker (#271)
2466946 
### Summary

Resolves #269 
Refactored code to improve code quality, removed redundant states and
unnecessary useEffects, adding memorization

### Checklist

- [x] look at the old code in Nathan's PR here -
#240
- [x] Refactor it and improve code quality (state, useEffect, CSS) as
you see fit. Some ideas - redundant state, unncessary useEffect
- [x] If time permits look over how gt-scheduler loads data. Start
reading at components/AppDataLoader.


### How to Test
Test adding recurring events on Scheduler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iphonecats iphonecats

Labels
task Task issue for a current or past sprint
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

brandon/269-finalize-new-time-picker gt-scheduler/website
2 participants
@yatharth-b @iphonecats