Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] IntoFuture for gio::Cancellable #1512

Open
felinira opened this issue Sep 22, 2024 · 1 comment
Open

[FEATURE REQUEST] IntoFuture for gio::Cancellable #1512

felinira opened this issue Sep 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@felinira
Copy link
Contributor

Could we implement IntoFuture for &IsA<gio::Cancellable> or at least for &gio::Cancellable? It's the standardized way to convert something into a future. We could even deprecate .future() in the former case.

It would allow to await cancellable directly, and not have to call a future method.

Maybe there are also other objects that could use an IntoFuture implementation, could be worth it to have a look.
@felinira felinira added the enhancement New feature or request label Sep 22, 2024
@sdroege
Copy link
Member

sdroege commented Sep 23, 2024

Sure, why not? Want to make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felinira @sdroege