Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait event doesn't create on init #41

Closed
JamesArruda opened this issue Mar 3, 2025 · 1 comment · Fixed by #42
Closed

Wait event doesn't create on init #41

JamesArruda opened this issue Mar 3, 2025 · 1 comment · Fixed by #42

Comments

@JamesArruda
Copy link
Collaborator

The Wait event doesn't create _simpy_event during init, which hurts some sanity checking for MultiEvent use cases.

@JamesArruda
Copy link
Collaborator Author

There's a deeper problem here where the way _simpy_event (or the equivalents in other events) work is they make fresh versions of themselves each time as_event() is called. In SimPy, you can yield back an existing timeout and will end at the originally intended time. SimPy puts timeouts on the _queue as soon as they are created, and .callbacks are added or removed as the timeouts are yielded, or things like Any finish.

It's bad to have this mismatch between SimPy behavior and UPSTAGE behavior, so this ticket should make all events match the same behavior.

@JamesArruda JamesArruda linked a pull request Mar 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant