-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facia: Decommission /lite.json
endpoint & renderFrontJsonMinimal()
, reduce memory consumption
#27143
Comments
We should pull this into our next health sprint |
Steps:
|
Cannot find any metrics for users in the 1% test: https://logs.gutools.co.uk/s/dotcom/goto/7f66b430-65e8-11ef-9afb-57c59e22107a UPDATE: I had forgot to switch the test on! https://frontend.gutools.co.uk/dev/switchboard Test switched on at 11:30am 3/9/24 |
When restarting work on this ticket, give the Fairground team a heads up, as they are working on the fronts and this may affect them |
See #26338 (comment) - back in November 2017, #18364 & #18365 introduced the
/lite.json
representation of fronts:frontend/facia/conf/routes
Lines 36 to 39 in 8bc978e
The
lite.json
versions are actually not significantly smaller:...and having 2 versions actually takes up additional memory that we could free up. Consequently I believe the the 'lite' versions should be completely removed.
Things to check...
See if the output of the endpoints that use the 'lite' versions (
renderFrontHeadline()
,renderFrontPressResult()
&renderFrontJsonMinimal()
) stays the same, depending whether they perform their own trimming that will work on the full versions ofPressedPage
, or if were relying on the trimmed nature of the 'lite' version at all.The text was updated successfully, but these errors were encountered: