Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated snapshot publishing for guardrail modules #1860

Closed
ptrdom opened this issue Oct 29, 2023 · 3 comments · Fixed by #1862
Closed

Automated snapshot publishing for guardrail modules #1860

ptrdom opened this issue Oct 29, 2023 · 3 comments · Fixed by #1862

Comments

@ptrdom
Copy link
Contributor

ptrdom commented Oct 29, 2023

Currently snapshots are not published in between releases, it would be neat to have them for early adoption of new features.

Looking at the release process, I do not think it is possible to implement snapshots without changes to it, because each module being released separately does not play well with automation of tools like sbt-ci-release and sbt-dynver, because it is difficult to determine which modules in the sbt project change and which of them require version bumps in an automated way.

Having this in mind, I see only two ways to implement snapshots:

  1. Release whole repository under a single version.
  2. Split modules up to their own repos.

Since there are tradeoffs in proposed changes, I guess the question is - manual release process with correctly enforced version policy for all modules or having automated snapshot publishing, which of these is more beneficial? I am obviously leaning towards the latter, but I might be missing some details on why release process for guardrail is the way it is now.

Thoughts?

@blast-hardcheese
Copy link
Member

Thank you for the writeup!

A single version was causing unnecessary version bumps and CI hours wasted for users, bumping a Java module shouldn't cause a version bump PR for Scala users and vice versa.

Split modules may be coming soon, but I'm still holding on as long as I can, since loading the entire project int a single sbt instance is still very convenient. (It may be possible to still load them all into a single runtime by way of ProjectRef, but I haven't attempted that yet).

All that being said, however, reading through your links got me to realize that I think we were only limited by useReadableConsoleGit (until sbt/sbt-git#238 is merged, at least!) as well as a parameter to the release action. We're already using sbt-ci-release, and I've done all the work to get the module version derived by tag, so it might just work.

@blast-hardcheese
Copy link
Member

Hmm. I didn't close that intentionally.

@blast-hardcheese
Copy link
Member

Ok. Manual snapshots cut, for now at least.

[info] guardrail-core / version
[info] 	0.75.3-SNAPSHOT
[info] guardrail-scala-support / version
[info] 	0.75.3-SNAPSHOT
[info] guardrail-scala-http4s / version
[info] 	0.76.1-SNAPSHOT
[info] guardrail-scala-akka-http / version
[info] 	0.76.0-SNAPSHOT

NB: You need to explicitly libraryDependencies ++= Seq(...) all of these in your project/guardrail.sbt, since the ABI has been broken as we work up to 1.0.

Closing this for now, after confirming that the snapshot for guardrail-core was published to s01.oss.sonatype.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants