Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch logging to avoid mixing logs from async code #72

Open
phated opened this issue Apr 5, 2016 · 6 comments
Open

Batch logging to avoid mixing logs from async code #72

phated opened this issue Apr 5, 2016 · 6 comments

Comments

@phated
Copy link
Member

phated commented Apr 5, 2016

Ref gulpjs/gulp#361

@BurtHarris
Copy link

@phated this topic interests me. Might be something I could help with.

Is there you got anything written down about logging principles in gulp? I'm particularly interested in logging from external tools, which might well be running async. It seems reasonable we might batch up such logging but not display it unless there is an error, and provide hooks for extracting meaningful information from the output. For example, I've got a tool which says things like

Generating file 'C:\code\antlr4ts\src\tree\xpath\.\XPathLexer.ts' for grammar 'XPathLexer.g4'
Generating file 'C:\code\antlr4ts\src\tree\xpath\.\XPathLexer.tokens' for grammar 'XPathLexer.g4'

Which seems like it might map well into output vinyl files rather than logging output, provided everything works.

@BurtHarris
Copy link

Seems like this doesn't belong in the cli project, am I mistaken?

@phated
Copy link
Member Author

phated commented Jun 7, 2017

The CLI converts messages from https://github.com/gulpjs/gulplog into console.log, so yes, it belongs here.

@radum
Copy link

radum commented Oct 20, 2017

Can we abstract out the logging part out of the CLI one can use whatever logging method one needs?

We could have the default behaviour there, but external logging services could be used to suppress the default one. This will solve this problem and many others I guess.

For me now in particular I'm considering moving away from gulp just because of this where I can't control how the task resolutions are logged.

@yocontra
Copy link
Member

@radum Your comment is unrelated to this issue, you should open a new ticket if you have a suggestion. Sounds like you want to be able to overwrite the logger the CLI uses with your own, which is a feature suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants