Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exceptions for scraping errors #16

Open
guoguo12 opened this issue Apr 6, 2017 · 3 comments
Open

Throw exceptions for scraping errors #16

guoguo12 opened this issue Apr 6, 2017 · 3 comments

Comments

@guoguo12
Copy link
Owner

guoguo12 commented Apr 6, 2017

As suggested in #15, we should catch errors during the scraping process and wrap them in a new kind of exception. We can use the "spotify-rewind" playlist as a test.
@guoguo12
Copy link
Owner Author

Update: the "spotify-rewind" chart no longer exists.

@guoguo12
Copy link
Owner Author

Also, we should fail loudly when the chart downloaded has zero entries. See #23 for an example of when this would have helped.

@guoguo12
Copy link
Owner Author

#40 is related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guoguo12