Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo chat #17

Open
gwarby opened this issue Dec 13, 2023 · 10 comments
Open

Repo chat #17

gwarby opened this issue Dec 13, 2023 · 10 comments

Comments

@gwarby
Copy link
Owner

gwarby commented Dec 13, 2023

@lcdnbl I would be most grateful if you were to upload the updated code from yesterday. Please and thank you.

@lcdnbl
Copy link
Collaborator

lcdnbl commented Dec 14, 2023

@gwarby LOL - my bad!
You'll find the newest versions I could find in the branch: working_code_Dec09_2023

@lcdnbl
Copy link
Collaborator

lcdnbl commented Dec 14, 2023

@gwarby One thing that kept me from tossing this code in sooner, is that it doesn't include a lot of really good ideas you've dev'ed in the branches. But unfortunately much of your code hasn't been proven & fine-tuned on the practice field, so the working competition code (in the new branch I mention above) is probably what we need to run - at least in the Sat 12/16/23 meet.

Notable to-do's:

  • BlueBackPixel hasn't had the mod to pick up pixels on init (and NOT in left-mid-right code blocks)
  • All code needs update to use the new arm-lower-limiting block (servo activated) to rest the arm (armraise motor) on top of while dropping off the first pixel & re-grabbing the 'top' pixel

@gwarby
Copy link
Owner Author

gwarby commented Dec 15, 2023

@lcdnbl I'll create a branch off of yours that implements my time saves and the new arm limiter, along with blueBackPixel picking up on init. Regardless of how much of that we actually achieve tomorrow night, I'll leave all the branches separated. Hopefully that will prevent any bad code needing to be run 12/16/23.

@lcdnbl
Copy link
Collaborator

lcdnbl commented Dec 16, 2023

@gwarby I checked in tho code on the robot after the meet, merged into the new competition stable branch, and deleted 'the other' branch. As far as I can tell, I didn't clobber any pending/candidate/untested time saving code.

...and maybe we should just rename this issue "repo chat" or some such thing.

@lcdnbl
Copy link
Collaborator

lcdnbl commented Dec 16, 2023

@gwarby I compared RedFrontPixelMatch10Config to RedFrontPixel, because I was concerned that we tweaked RedFrontPixel after making the copy. But, other than the 3.5 second delay(s) & the name change, they match.

@gwarby gwarby changed the title Somebody won't upload the code from meetings Repo chat Dec 17, 2023
@lcdnbl
Copy link
Collaborator

lcdnbl commented Dec 19, 2023

@gwarby Today's bot spot practice code is in the common_auto_functions branch (which we should probably merge onto/over the competition ready branch)

@gwarby
Copy link
Owner Author

gwarby commented Dec 22, 2023

@lcdnbl I don't know if we ever laid down a time for tonight, but Harry and I have swim until 6. I would guess any time after 6:15 would work.

@lcdnbl
Copy link
Collaborator

lcdnbl commented Dec 22, 2023

@gwarby @Harrison879
@chrisgeerts told me earlier that he is really busy & has family xmas tomorrow. So no meeting today. As far as I know, next Friday was the next potential date for an extra programming session.

@lcdnbl
Copy link
Collaborator

lcdnbl commented Jan 5, 2024

@gwarby If there are more changes you want to work on, I'd encourage you to merge PR #26 then make another branch for the offline work.

@lcdnbl
Copy link
Collaborator

lcdnbl commented Jan 7, 2024

@gwarby if you want to work on the code offline I would suggest:

  • merge PR Wip/mtg fri 1 5 2024 #27 into stable/competition
  • create a new branch from stable/competition called something like 'wip/offline_post_fri_1_5'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants