Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading note on README #55

Open
russointroitoa opened this issue Dec 12, 2022 · 0 comments
Open

Misleading note on README #55

russointroitoa opened this issue Dec 12, 2022 · 0 comments

Comments

@russointroitoa
Copy link
Contributor

russointroitoa commented Dec 12, 2022

I noticed that one of the first lines of README states:

NOTE: As of 1.0 batch_size renamed to batch_flush_size

However, the two variables have clearly different meanings. The former defines the number of items per batch, the latter, instead, states how many items you should fetch from Redis each time. In other words, batch_flush_size is the pluck_size and batch_size is the chunk_size; therefore if you choose batch_flush_size=5000 and batch_size=100, you will obtain 5000/100 = 50 batches.

As it is written on the README, it seems that the two parameters are the same, but in my understanding they are different.

Playing with those two parameters could be useful to increase the speed of batches creation (and maybe solve this issue)

Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant