Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration_test.rs:75-77: Create similar integration... #158

Open
0pdd opened this issue Sep 19, 2024 · 0 comments · May be fixed by #159
Open

integration_test.rs:75-77: Create similar integration... #158

0pdd opened this issue Sep 19, 2024 · 0 comments · May be fixed by #159
Assignees
@h1alexbel
Labels
bug Something isn't working pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 19, 2024

The puzzle 129-5278c7d1 from #129 has to be resolved:

fakehub/cli/tests/integration_test.rs

Lines 75 to 77 in 1bd7585

// @todo #129:60min Create similar integration test for windows platform.
// Now we have test for linux and macos. However, we need to maintain
// similar test case for windows as well.

The puzzle was created by @h1alexbel on 19-Sep-24.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added bug Something isn't working pdd labels Sep 19, 2024
0pdd referenced this issue Sep 19, 2024
@h1alexbel
Merge pull request #156 from h1alexbel/129
1bd7585 
feat(#129): -d for detached run
@0pdd 0pdd mentioned this issue Sep 19, 2024
Closed
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): win kill
994f986
@h1alexbel h1alexbel linked a pull request Sep 20, 2024 that will close this issue
Draft
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): taskkill
a2e0296
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): check which works
313e215
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): back
abc0233
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): eprint
0ba0f46
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): out print
149c4be
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): npm kill-port
b3be492
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): no cmd
02556ae
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): try new process, no window flags
6091246
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): flags before args
537e3f6
@h1alexbel h1alexbel self-assigned this Sep 20, 2024
h1alexbel added a commit that referenced this issue Sep 20, 2024
@h1alexbel
feat(#158): no unused on win
9a0c8c3
l3r8yJ added a commit that referenced this issue Sep 21, 2024
@l3r8yJ
chore(#158): test without defer
6224c8c
l3r8yJ added a commit that referenced this issue Sep 21, 2024
@l3r8yJ
Revert "chore(#158): test without defer"
39e19fd 
This reverts commit 6224c8c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h1alexbel h1alexbel

Labels
bug Something isn't working pdd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#158): kill detached process on win h1alexbel/fakehub
2 participants
@0pdd @h1alexbel