Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login endpoint without credentials at all #22

Open
h1alexbel opened this issue Jun 5, 2024 · 5 comments
Open

login endpoint without credentials at all #22

h1alexbel opened this issue Jun 5, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@h1alexbel
Copy link
Owner

h1alexbel commented Jun 5, 2024

as we creating tool that is designed to be used primary for testing, I suggest to make login credentials-free. users will decide which login to use only when they bootstrap:

fakehub start # view as incognito
fakehub start --user h1alexbel # view fakehub as @h1alexbel

@l3r8yJ WDYT?

@h1alexbel h1alexbel added the question Further information is requested label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

@h1alexbel thanks for the report, here is a feedback:

Problems

  1. Lack of clear problem statement: The report does not clearly state the problem or the issue it is reporting. It simply gives a suggestion about making the login credentials-free and asks for others' opinions on this idea.

  2. Missing context: The report lacks necessary context about the current system, functionality, or user experience. It is unclear why the login process needs to be changed or what the impact of this change will be.

  3. Absence of steps to reproduce: There are no steps provided to reproduce the issue or verify a proposed solution. It is essential to provide clear, step-by-step instructions so that others can understand, reproduce, and potentially fix the issue.

I would recommend clearly stating the problem or issue in the bug report, as it will help others understand the nature of the problem and the suggested solution.

Please fix the bug report in order it to get resolved faster.
Analyzed with Phind/Phind-CodeLlama-34B-v2

@l3r8yJ
Copy link
Collaborator

l3r8yJ commented Jun 5, 2024

@h1alexbel hm, maybe let's use --user then, not --login, login implies process of authorisation? Password should be the same as the user nickname

@h1alexbel
Copy link
Owner Author

@l3r8yJ let's use --user, btw in this case we can remove passwords from fakehub, since users don't need to use them

@l3r8yJ
Copy link
Collaborator

l3r8yJ commented Jun 5, 2024

@h1alexbel can you assign it to me?

@l3r8yJ l3r8yJ added enhancement New feature or request and removed question Further information is requested labels Jun 5, 2024
@h1alexbel
Copy link
Owner Author

@l3r8yJ assigned, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants