Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routes_it.rs:38-40: Check home response from body. We... #87

Open
0pdd opened this issue Jul 18, 2024 · 2 comments
Open

routes_it.rs:38-40: Check home response from body. We... #87

0pdd opened this issue Jul 18, 2024 · 2 comments
Labels
bug Something isn't working pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 18, 2024

The puzzle 79-11f081e9 from #79 has to be resolved:

// @todo #79:25min Check home response from body.
// We should check that returned home body contains exactly the same response that
// in resources/home.json (expected). Don't forget this puzzle.

The puzzle was created by rultor on 18-Jul-24.

Estimate: 25 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Copy link

@0pdd thanks for the report, here is a feedback:

  • The todo message is not clear about what exactly needs to be checked in the home response body. It would be better if the message specified what exactly is expected to be checked in the home response body or what kind of discrepancies should be caught.
  • The todo message does not provide any context on why this check is important or what issues might arise if it is not addressed. If there is a specific reason why this check is needed, it would be helpful for the other codebase contributor to understand the context.
  • Overall, the todo message could be improved by providing more specific details about what needs to be checked and why, which would help the other codebase contributor understand the importance of this task and how to approach it.

Please fix the bug report in order it to get resolved faster.
Analyzed with Phind/Phind-CodeLlama-34B-v2

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 18, 2024

@0pdd thanks for the report, here is a feedback: * The todo message is not clear about what exactly ...

I see you're talking to me, but I can't reply since I'm not a chat bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdd
Projects
None yet
Development

No branches or pull requests

1 participant