Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which HTTP client(s) should we support and which should be the default? #1

Open
h4l opened this issue Sep 25, 2024 · 0 comments
Open
Labels
question Further information is requested

Comments

@h4l
Copy link
Owner

h4l commented Sep 25, 2024

Currently using aiohttp. Pros: mature, apparently lightweight with good performance. Cons: no HTTP2 support. httpx supports async and http2 but has a reputation for being heavier than aiohttp. I've not seen actual benchmarks to back that up though. httpx is implemented on top of httpcore, which is a low-level HTTP library which uses h2 for HTTP2 support, and supports async. This looks like it could be a good option as we don't need any high level features that httpx provides by wrapping it.

It would be sub-optimal to depend on both aiohttp and httpcore, so if we do support both it seems like we should either make both optional, or support one by default and make the other optional.

@h4l h4l added the question Further information is requested label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant