Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event notifications #17

Open
marzavec opened this issue Dec 14, 2020 · 2 comments
Open

Event notifications #17

marzavec opened this issue Dec 14, 2020 · 2 comments
Labels
high priority Gotta get on this missing feature A feature that should be added to the client ui Issue deals mainly with the UI

Comments

@marzavec
Copy link
Member

Notifications need to be added. I was thinking of using react-web-notification for compatibility reasons and it's built-in service worker handling.

Notifications should be built to check if the window has focus, as well as what channel currently has focus, allowing mentions in other background channels to be displayed.

@marzavec marzavec added missing feature A feature that should be added to the client high priority Gotta get on this ui Issue deals mainly with the UI labels Dec 14, 2020
@KnowsCount
Copy link
Contributor

sounds should play a big role in the notification part, concluding from my past experience using hack.chat. some sort of clearer reminder, at least. but as stated in react-web-notification:

Notification.sound Notification.sound is not supported in any browser. You can emulate it with onShow callback. see example.

there might be issues with sound... can this be solved?—I am personally not quite familiar with this notification thingy.

@marzavec
Copy link
Member Author

marzavec commented Jun 1, 2021

can this be solved?

Yep, should be easy enough, compatibility will be the biggest hurdle though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Gotta get on this missing feature A feature that should be added to the client ui Issue deals mainly with the UI
Projects
None yet
Development

No branches or pull requests

2 participants