Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions diff, highlight changes since previous preview #568

Closed
grmpyninja opened this issue Oct 9, 2017 · 4 comments
Closed

Versions diff, highlight changes since previous preview #568

grmpyninja opened this issue Oct 9, 2017 · 4 comments
Labels
feature Wants to add a new feature needs info There is some information missing

Comments

@grmpyninja
Copy link

It'd be awesome to see, some kind of a changelog since the last preview of the note. It'd be really useful to e.g. go to the editor and save the state of it (maybe based on git versioning suggested somewhere) and then when another users does the modifications to see the changes between the last and the current version of the note. Also adding the authors would be simply brilliant, but I guess it might be a bit to much to implement at once (similar to etherpad's highlighting authors).

@SISheogorath SISheogorath added the feature Wants to add a new feature label Oct 9, 2017
@SISheogorath
Copy link
Contributor

I'm not sure if I got you right, so it would be nice to clear some things up.

Right now we provide the revisions, which are diffs over time.

Revisions

If we want to show some kind of diff since the last visit, it would be enough to keep the revision id per user per note and mark the diff in one or another way.


As a second feature, you want the Authors highlighted. Now is the big question: Where? In the editor? Or in the revision view like it was requested in #312?

If that's really another feature request, we should move it to an own issue, because, otherwise, it becomes more difficult to handle this one.

@SISheogorath SISheogorath added the needs info There is some information missing label Oct 10, 2017
@jmuheim
Copy link

jmuheim commented Nov 10, 2017

While I see a revision, it seems to be empty:

image

Is this a bug?

@ccoenen
Copy link
Contributor

ccoenen commented Nov 10, 2017

@jmuheim This is a bug, I would like to ask you to open another ticket, so we can discuss/triage it there.

@jackycute
Copy link
Member

Hi @jmuheim,

I know this is old, but that is not a bug, the very first revision of your note is empty because we create a baseline version of your note at creation.
BTW, we already support showing diffs in revisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Wants to add a new feature needs info There is some information missing
Projects
None yet
Development

No branches or pull requests

5 participants