Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply scale parameter #6

Open
jo-mueller opened this issue Mar 9, 2022 · 2 comments
Open

Apply scale parameter #6

jo-mueller opened this issue Mar 9, 2022 · 2 comments

Comments

@jo-mueller
Copy link
Collaborator

When working with parameters like curvature, I think it is dangerous to have the scale parameter set in the layer properties. ´This could lead to a sphere appearing perfectly spherical while, in fact, being ellipsoidal.

We could fix this by introducing a small function that "applies" the scale parameter to the points in points/surface layers as this wouldn't change the actual amount of data to be handled - unlike with image data.

@haesleinhuepf
Copy link
Owner

Then it would also make sense to multiply the voxel size with the vertices, after applying marching cubes, right?

E.g. here:
https://github.com/haesleinhuepf/napari-process-points-and-surfaces/blob/main/napari_process_points_and_surfaces/__init__.py#L424

And the opposite should be done here, I think:
https://github.com/haesleinhuepf/napari-process-points-and-surfaces/blob/main/napari_process_points_and_surfaces/__init__.py#L333

@jo-mueller
Copy link
Collaborator Author

Yes, exactly! PR coming soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants