Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about "HEAT_DEMAND_RULE_WITH_LEAD_ROOM" #481

Open
Nihilissimis opened this issue Jan 24, 2023 · 2 comments
Open

Warnings about "HEAT_DEMAND_RULE_WITH_LEAD_ROOM" #481

Nihilissimis opened this issue Jan 24, 2023 · 2 comments

Comments

@Nihilissimis
Copy link

I'm getting two warnings mentioning HEAT_DEMAND_RULE_WITH_LEAD_ROOM:
1: homematicip.base.enums - WARNING - 'HEAT_DEMAND_RULE_WITH_LEAD_ROOM' isn't a valid option for class 'GroupType'
2: homematicip.home - WARNING - There is no class for group 'HEAT_DEMAND_RULE_WITH_LEAD_ROOM' yet

As far as I can tell this is coming from the HmIP-WHS2 Boiler switch that has this as assignment on one of the ports.

I took a quick stab at trying to fix this, but not familiar with the code and it seems that the group definitions are a bit complex. Happy to help/provide more information if needed.

@hahn-th
Copy link
Owner

hahn-th commented Jan 25, 2023

Yes of course. you can contact me via Discord or Email

@hahn-th
Copy link
Owner

hahn-th commented Jan 25, 2023

You have to do following things:

  • create the group class in group.py
  • create the async version in aio/group.py
  • add group type from json dump in base/enums.py -> GroupType Enum
  • assign your class from group.py to class_maps TYPE_GROUP_MAP
  • assign your async class from aio/group.py to TYPE_GROUP_MAP in aio/class_maps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants