From 226c5c3bfc368e4d1e5e3be300d5c62c2338a99c Mon Sep 17 00:00:00 2001 From: Halo Dev Bot <87291978+halo-dev-bot@users.noreply.github.com> Date: Fri, 5 Jul 2024 18:45:07 +0800 Subject: [PATCH] [release-2.17] fix: bubble menu not appearing when crossing lines in editor (#6283) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is an automated cherry-pick of #6268 /assign ruibaby ```release-note 修复默认编辑器中跨行选择节点时冒泡菜单无法出现的问题 ``` --- ui/packages/editor/src/extensions/text/index.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/packages/editor/src/extensions/text/index.ts b/ui/packages/editor/src/extensions/text/index.ts index b3d0a3889f..0d41fc388f 100644 --- a/ui/packages/editor/src/extensions/text/index.ts +++ b/ui/packages/editor/src/extensions/text/index.ts @@ -1,6 +1,7 @@ import ColorBubbleItem from "@/extensions/color/ColorBubbleItem.vue"; import HighlightBubbleItem from "@/extensions/highlight/HighlightBubbleItem.vue"; import LinkBubbleButton from "@/extensions/link/LinkBubbleButton.vue"; +import { RangeSelection } from "@/extensions/range-selection"; import { i18n } from "@/locales"; import type { EditorState } from "@/tiptap/pm"; import { isActive, isTextSelection } from "@/tiptap/vue-3"; @@ -56,7 +57,10 @@ const Text = TiptapText.extend({ return false; } - if (!isTextSelection(selection)) { + if ( + !isTextSelection(selection) && + !(selection instanceof RangeSelection) + ) { return false; }