Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary Conversion of info to NumPy #791

Open
hesic73 opened this issue Jan 7, 2025 · 1 comment · May be fixed by #796
Open

Unnecessary Conversion of info to NumPy #791

hesic73 opened this issue Jan 7, 2025 · 1 comment · May be fixed by #796

Comments

@hesic73
Copy link
Contributor

hesic73 commented Jan 7, 2025

ManiSkill/mani_skill/utils/wrappers/record.py

Line 517 in 42d4fcf

self._last_info = common.to_numpy(info)

This line seems unnecessary since self._last_info is never used. Additionally, this conversion can fail for certain info dictionaries, raising an exception.
@StoneT2000
Copy link
Member

You are right, we can remove this line of code, happy to accept a PR

hesic73 added a commit to hesic73/ManiSkill that referenced this issue Jan 8, 2025
@hesic73
Remove unnecessary conversion of info to NumPy (haosulab#791)
e81abfa 
The conversion of `info` to NumPy in `self._last_info` is unnecessary as `self._last_info` is never used. This line could also raise exceptions for certain `info` dictionaries. Fixes haosulab#791.
@hesic73 hesic73 linked a pull request Jan 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary conversion of info to NumPy (#791) hesic73/ManiSkill
2 participants
@StoneT2000 @hesic73