-
-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haraka fails to read docs/Plugins.md
after installation on 3.0.4
#3394
Comments
There are additional issues as well. For instance, in the hook_delivered params, the host is mistakenly set as the IP address. Additionally, the mailauth plugin's SPF check consistently fails. |
Same here. If I manually copy But fails like this:
I guess b/c the |
Plugins.md needs to be installed in the docs folder, e.g. /etc/haraka/docs/ |
I confirmed that Plugins.md is being installed in the docs folder and help is working as expected. |
@msimerson still not fixed for 3.0.5. Steps for reproducing are the same:
output
full reproducing steps
|
@tyranron , please try this patch against the haraka 'binary' in your path. It should resolve the issue, and if not it'll at least provide a useful message. diff --git a/bin/haraka b/bin/haraka
index 170bfbe7..0db61428 100755
--- a/bin/haraka
+++ b/bin/haraka
@@ -228,7 +228,8 @@ const plugin_doc = [
function getHooks () { // see haraka/Haraka#3306
- return fs.readFileSync('docs/Plugins.md').toString()
+ const pi_path = path.resolve(parsed.configs, 'docs', 'Plugins.md')
+ return fs.readFileSync(pi_path).toString()
.split('## Available Hooks')[1] // discard everything before this string
.split('### rcpt')[0] // discard everything after this string
.match(/\*\s(\S+)/gm) // grab the first word of lines starting with '* ' Reminder to self: paths should always be assembled using |
@s-aga-r, Please create separate issues for stuff like this. Preferably in the repo where the issue is. postalsys/haraka-plugin-mailauth#3 should fix that. |
I just installed in on a clean Debian 12 and it is working as expected.
|
I also confirmed that @msimerson's patch also works. |
@msimerson I do confirm that the patch works. repro
|
Describe the bug
Expected behavior
Something like:
Observed behavior
Additional context
3.0.3 works OK.
The text was updated successfully, but these errors were encountered: