diff --git a/.changelog/24316.txt b/.changelog/24316.txt new file mode 100644 index 00000000000..4cf0785f6ae --- /dev/null +++ b/.changelog/24316.txt @@ -0,0 +1,3 @@ +```release-note:bug +ui: Fix an issue where cmd+click or ctrl+click would double-open a var +``` diff --git a/ui/app/components/variable-paths.js b/ui/app/components/variable-paths.js index 3b5719b6459..abdb5a83739 100644 --- a/ui/app/components/variable-paths.js +++ b/ui/app/components/variable-paths.js @@ -26,13 +26,27 @@ export default class VariablePathsComponent extends Component { } @action - async handleFolderClick(path) { + async handleFolderClick(path, trigger) { + // Don't navigate if the user clicked on a link; this will happen with modifier keys like cmd/ctrl on the link itself + if ( + trigger instanceof PointerEvent && + /** @type {HTMLElement} */ (trigger.target).tagName === 'A' + ) { + return; + } this.router.transitionTo('variables.path', path); } @action - async handleFileClick({ path, variable: { id, namespace } }) { + async handleFileClick({ path, variable: { id, namespace } }, trigger) { if (this.can.can('read variable', null, { path, namespace })) { + // Don't navigate if the user clicked on a link; this will happen with modifier keys like cmd/ctrl on the link itself + if ( + trigger instanceof PointerEvent && + /** @type {HTMLElement} */ (trigger.target).tagName === 'A' + ) { + return; + } this.router.transitionTo('variables.variable', id); } } diff --git a/ui/app/controllers/variables/index.js b/ui/app/controllers/variables/index.js index deddbb910d2..b214b342f56 100644 --- a/ui/app/controllers/variables/index.js +++ b/ui/app/controllers/variables/index.js @@ -15,11 +15,6 @@ export default class VariablesIndexController extends Controller { isForbidden = false; - @action - goToVariable(variable) { - this.router.transitionTo('variables.variable', variable.path); - } - @action goToNewVariable() { this.router.transitionTo('variables.new'); }