Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Passing options to hlint-run? #110

Closed
philderbeast opened this issue Jul 11, 2022 · 5 comments
Closed

Passing options to hlint-run? #110

philderbeast opened this issue Jul 11, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed re: hlint Concerning the hlint actions

Comments

@philderbeast
Copy link

philderbeast commented Jul 11, 2022

With hlint-run, I'm able to pass in folders to this action doing the equivalent of:

hlint src/

Using the action how would we pass options like --cpp-define and --cpp-simple?

hlint src/ --cpp-define=WINDOWS=1
hlint test/ --cpp-simple

https://github.com/commercialhaskell/stack/blob/af098aa6a8246960229871228c5ed757e29916ad/.github/workflows/unit-tests.yml#L24-L26

@andreasabel andreasabel added enhancement New feature or request help wanted Extra attention is needed re: hlint Concerning the hlint actions labels Jan 5, 2023
@mihaimaruseac
Copy link
Contributor

@philderbeast can you move this to https://github.com/haskell-actions/hlint-run please? This repo is winding down, the actions got split into separate repos

@philderbeast
Copy link
Author

Will do, next week.

@philderbeast
Copy link
Author

@mihaimaruseac it looks like I can't transfer this issue from github.com/haskell/actions to github.com/haskell-actions/hlint-run because they are different organisations. Happy to recreate it there and close this one if that is the case.

@mihaimaruseac
Copy link
Contributor

Please open one there and close this one.

The idea to opening it yourself instead of us is that this way you will be notified when fixed, as this repo will get disabled, I think.

@philderbeast
Copy link
Author

Same issue opened as haskell-actions/hlint-run#20.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed re: hlint Concerning the hlint actions
Projects
None yet
Development

No branches or pull requests

3 participants