Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save GHC version in stored pastes #15

Open
tomsmeding opened this issue Feb 9, 2023 · 3 comments
Open

Save GHC version in stored pastes #15

tomsmeding opened this issue Feb 9, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tomsmeding
Copy link
Collaborator

Currently when loading a stored paste, the playground just selects the default GHC version, rather than the version selected when the paste was created. This is annoying when wanting to demonstrate behaviour with one particular GHC version.

@tomsmeding tomsmeding added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 9, 2023
@trevorsibanda
Copy link

Hi @tomsmeding I'd like to start on this. Any tips or anything I should be aware of?

@tomsmeding
Copy link
Collaborator Author

Thanks! I expect that you'll need to do the following things:

  • Change the database schema in play-haskell-server/src/DB.hs (don't forget to up the version number)
  • Write a DB migration script like the existing migrate_db_N_M.sh
  • Modify the Save endpoint in Play.hs to take a JSON value instead of plain bytes (look at other endpoints how that might work) -- also looks like that endpoint could use a exitExitEarlyT
  • Modify the client in play.mustache to do the right thing

Let me know if you get stuck!

@trevorsibanda
Copy link

Opened a draft PR.

Comments welcome before I move forward tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants