Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(advntr): TypeError: cannot convert float NaN to integer during genotype command #63

Open
berntpopp opened this issue Dec 24, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@berntpopp
Copy link
Collaborator

When running the pipeline subcommand with --extra-modules advntr, a TypeError occurs in the adVNTR HMM alignment step:

2024-12-24 12:28:51,082 - root - ERROR - Error during processing of deletions and insertions: cannot convert float NaN to integer
...
TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'

This error prevents adVNTR from completing successfully and halts the pipeline.

Steps to Reproduce

  1. Run vntyper pipeline --bam /path/to/example.bam --threads 4 --reference-assembly hg19 --keep-intermediates -o out/example_1 --archive-results --extra-modules advntr
  2. Observe the TypeError in the output log.

Expected Behavior

  • Pipeline should complete adVNTR genotyping without encountering a TypeError.
  • Any potential NaN or NoneType values should be handled gracefully or converted properly.

Environment

  • advntr==1.3.3
  • vntyper==2.0.0-alpha.xx (or current version)
  • Python version, OS, conda environment details, etc.

Additional Context

  • A potential fix exists in a private branch: enhanced_hmm. Requires thorough testing before merging.

Possible Solutions

  • Merge the enhanced_hmm branch changes into the main or stable branch of adVNTR.
  • Add checks to handle NaN or type mismatches inside the HMM alignment logic.
@berntpopp berntpopp added the enhancement New feature or request label Dec 24, 2024
@berntpopp berntpopp self-assigned this Dec 24, 2024
@berntpopp berntpopp pinned this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant