FREERTOS thread create in different order cause memory leak.

[favoritewky]

Operating System

Windows 11

Board

stm32g0b1ret6

Firmware

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2019 Ha Thach (tinyusb.org)
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 */

#ifndef _TUSB_CONFIG_H_
#define _TUSB_CONFIG_H_

#include "tusb_option.h"

#ifdef __cplusplus
 extern "C" {
#endif

//--------------------------------------------------------------------
// COMMON CONFIGURATION
//--------------------------------------------------------------------

// defined by board.mk

#define CFG_TUSB_MCU OPT_MCU_STM32G0 // target config
#ifndef CFG_TUSB_MCU
  #error CFG_TUSB_MCU must be defined
#endif

// RHPort number used for device can be defined by board.mk, default to port 0
#ifndef BOARD_DEVICE_RHPORT_NUM
  #define BOARD_DEVICE_RHPORT_NUM     0
#endif

// RHPort max operational speed can defined by board.mk
// Default to Highspeed for MCU with internal HighSpeed PHY (can be port specific), otherwise FullSpeed
#ifndef BOARD_DEVICE_RHPORT_SPEED
  #if (CFG_TUSB_MCU == OPT_MCU_LPC18XX || CFG_TUSB_MCU == OPT_MCU_LPC43XX || CFG_TUSB_MCU == OPT_MCU_MIMXRT10XX || \
       CFG_TUSB_MCU == OPT_MCU_NUC505  || CFG_TUSB_MCU == OPT_MCU_CXD56)
    #define BOARD_DEVICE_RHPORT_SPEED   OPT_MODE_HIGH_SPEED
  #else
    #define BOARD_DEVICE_RHPORT_SPEED   OPT_MODE_FULL_SPEED
  #endif
#endif

// Device mode with rhport and speed defined by board.mk
#define CFG_TUSB_RHPORT0_MODE     (OPT_MODE_DEVICE | BOARD_DEVICE_RHPORT_SPEED)


#define CFG_TUSB_OS               OPT_OS_FREERTOS

// CFG_TUSB_DEBUG is defined by compiler in DEBUG build
 #define CFG_TUSB_DEBUG           3

/* USB DMA on some MCUs can only access a specific SRAM region with restriction on alignment.
 * Tinyusb use follows macros to declare transferring memory so that they can be put
 * into those specific section.
 * e.g
 * - CFG_TUSB_MEM SECTION : __attribute__ (( section(".usb_ram") ))
 * - CFG_TUSB_MEM_ALIGN   : __attribute__ ((aligned(4)))
 */
#ifndef CFG_TUSB_MEM_SECTION
#define CFG_TUSB_MEM_SECTION
#endif

#ifndef CFG_TUSB_MEM_ALIGN
#define CFG_TUSB_MEM_ALIGN          __attribute__ ((aligned(4)))
#endif

//--------------------------------------------------------------------
// DEVICE CONFIGURATION
//--------------------------------------------------------------------

#ifndef CFG_TUD_ENDPOINT0_SIZE
#define CFG_TUD_ENDPOINT0_SIZE    64
#endif

//#define USE_SOF 1 no sof for now

//------------- CLASS -------------//
#define HID_DIRECT

// Which classes are compiled and available
#define CFG_TUD_CDC               1
#define CFG_TUD_MSC               0
#define CFG_TUD_MIDI              0
#ifdef HID_DIRECT
#define CFG_TUD_HID               0
#else
#define CFG_TUD_HID               0
#endif
#define CFG_TUD_VENDOR            0
#define CFG_TUD_AUDIO			  0
#define CFG_TUD_DFU_RT            0

// CDC FIFO size of TX and RX
#define CFG_TUD_CDC_RX_BUFSIZE    512//(TUD_OPT_HIGH_SPEED ? 512 : 64)
#define CFG_TUD_CDC_TX_BUFSIZE    1024//(TUD_OPT_HIGH_SPEED ? 512 : 64)

//// MIDI FIFO size of TX and RX
//#define CFG_TUD_MIDI_RX_BUFSIZE   (TUD_OPT_HIGH_SPEED ? 512 : 64)
//#define CFG_TUD_MIDI_TX_BUFSIZE   (TUD_OPT_HIGH_SPEED ? 512 : 64)

// MSC Buffer size of Device Mass storage
#define CFG_TUD_MSC_EP_BUFSIZE    512


#ifdef __cplusplus
 }
#endif

#endif /* _TUSB_CONFIG_H_ */

What happened ?

#2704

After solve the probelm, I got a probelm with the different thread create order.

const osThreadAttr_t lcdtask_attributes = {
  .name = "lcdtask",
  .priority = (osPriority_t) osPriorityNormal,
  .stack_size = 128 * 4
};
/* Definitions for tinyusb */
osThreadId_t tinyusbHandle;
const osThreadAttr_t tinyusb_attributes = {
  .name = "tinyusb",
  .priority = (osPriority_t) osPriorityNormal1,
  .stack_size = 128 * 4
};

    tinyusbHandle = osThreadNew(tinyusbent, NULL, &tinyusb_attributes);
  lcdtaskHandle = osThreadNew(Startlcdtask, NULL, &lcdtask_attributes);

can work ok.

  lcdtaskHandle = osThreadNew(Startlcdtask, NULL, &lcdtask_attributes);
  tinyusbHandle = osThreadNew(tinyusbent, NULL, &tinyusb_attributes);

doesn't work.
Change the osPriority can't fix the problem.

How to reproduce ?

make tinyusb task as the 2nd created task will crash the program.
With tinyusb create first:


Everything works ok.

With tinyusb create 2nd:

I think there has a memory leak?

It seems that tinyusb task will crash the tbc block and cause the hard fault.

The FREERTOS lib comes from STM32Cube_FW_G0_V1.6.2 generate.

Debug Log as txt file (LOG/CFG_TUSB_DEBUG=2)

Logs here.

.USBD init on controller 0, Highspeed = 0
sizeof(usbd_device_t) = 53
sizeof(dcd_event_t) = 12
sizeof(tu_fifo_t) = 20
sizeof(tu_edpt_stream_t) = 112
CDC init
USBD Bus Reset : Full Speed

USBD Setup Received 80 06 00 01 00 00 40 00 
  Get Descriptor Device
  Queue EP 80 with 18 bytes ...

and crash.

Screenshots

No response

I have checked existing issues, dicussion and documentation

• I confirm I have checked existing issues, dicussion and documentation.

[favoritewky]

Increase stack size and heap size can fix this.