Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for specific ordering of events #5

Closed
krainboltgreene opened this issue Nov 4, 2020 · 2 comments
Closed

Allow for specific ordering of events #5

krainboltgreene opened this issue Nov 4, 2020 · 2 comments

Comments

@krainboltgreene
Copy link

So here's my output:

Screen Shot 2020-11-04 at 3 06 47 PM

While you can't tell, its:

  • query decode time
  • query idle time
  • query query time
  • query queue time
  • query total time
  • endpoint stop duration

However my install code looks like this:

    Plug.Telemetry.ServerTiming.install([
      {[:phoenix, :endpoint, :stop], :duration},
      {[:database, :repository, :query], :total_time},
      {[:database, :repository, :query], :decode_time},
      {[:database, :repository, :query], :query_time},
      {[:database, :repository, :query], :queue_time},
      {[:database, :repository, :query], :idle_time}
    ])

How are these orders so different?

@hauleth
Copy link
Owner

hauleth commented Sep 23, 2021

Current ordering depends on the order in which events happened in the application, not on the order of the events in the install/1 call. Reason for that is that in future I want to support total when w3c/server-timing#44 will land. Ordering events in the user-provided way may then be confusing default.

@hauleth hauleth closed this as completed Sep 23, 2021
@krainboltgreene
Copy link
Author

Oof, that's a rough problem, I can understand your hesitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants