Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https as default #352

Closed
acka47 opened this issue Aug 21, 2017 · 10 comments
Closed

Use https as default #352

acka47 opened this issue Aug 21, 2017 · 10 comments
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Aug 21, 2017

Like written in hbz/lobid-organisations#263 (for lobid-organisations) we should implement https as default in all our major services (lobid-resources, nwbib, lobid-authorites etc.).

@acka47
Copy link
Contributor Author

acka47 commented Oct 6, 2017

I have the suspicion that NWBib hits are declining heaviliy because we don't make it https by default. Obviously, google doesn't even index NWBib much anymore (8xxx), see https://www.google.de/search?source=hp&q=site%3Anwbib.de (On the other hand, most of the indexed pages are https.)

@dr0i
Copy link
Member

dr0i commented Oct 6, 2017

I have the suspicion that the search engines note that a link into a catalog is not what most users want when searching internet resources. But anyway.
Not sure if http status code 301 (Moved permanently) is what we want, as it is stated in https://en.wikipedia.org/wiki/HTTP_301 that:

links or records using the URL that the response is received for should be updated

which we ourselves won't do (I mean: using https-resource-URIs).
But then this status code seems to be most appreciated by the internet search giants. So. Test this:

http://test.nwbib.de/HT019242018
http://stage.lobid.org/resources/HT019242018
http://stage.lobid.org/organisations/DE-5

I don't use the permanent redirect in production yet because there is an web-app issue (play.api.Application$$anon$1: Execution exception[[ConnectException: HostnameVerifier exception.]] )like that described in "https://stackoverflow.com/questions/37630975/play-framework-ws-call-to-https-restful-api-throwing-exception-on-production".

@dr0i
Copy link
Member

dr0i commented Oct 6, 2017

Maybe its also correlated to https://stackoverflow.com/questions/19288803/trust-all-ssl-certificates-in-java-playframework-2-2.
To reproduce:
You can use the stage.lobid.org in test.nwbib.de for stage.lobid is configured with the https-redirect (which causes the problems).
Or, if you want to configure production vhosts, just add

RewriteCond %{HTTPS} !on
RewriteRule ^/?(.*) https://%{SERVER_NAME}/$1 [R=301]

to them conf's and restart graceful.

Note that for nwbib the http-redirects are productive, see e.g. http://nwbib.de/HT019242018.

@dr0i dr0i assigned fsteeg and unassigned dr0i Oct 6, 2017
@acka47
Copy link
Contributor Author

acka47 commented Oct 9, 2017

Not sure if http status code 301 (Moved permanently) is what we want, as it is stated in https://en.wikipedia.org/wiki/HTTP_301 that:

links or records using the URL that the response is received for should be updated

I think we should use 301. We should just make sure that all internal lobid links in the HTML are HTTPS. Most of them already are but not all.

The JSON we serve is JSON-LD (Linked Data) we are using HTTP URIs as discussed in hbz/lobid-organisations#263 because it seems to be best practice.

@acka47
Copy link
Contributor Author

acka47 commented Nov 27, 2017

We still don't have https as default, see also hbz/lobid-organisations#263. As written in https://go-to-hellman.blogspot.de/2017/09/prepare-now-for-topical-storm-chrome-62.html our search boxes are now labeled as "not secure" in Chrome.

@acka47
Copy link
Contributor Author

acka47 commented Jun 26, 2019

We should just implement this. It is time.

@dr0i
Copy link
Member

dr0i commented Jul 8, 2019

Https as default for:

@dr0i
Copy link
Member

dr0i commented Jul 8, 2019

@acka47 please have a look, all should be redirected permanently to https.

@dr0i dr0i assigned acka47 and unassigned dr0i Jul 8, 2019
dr0i added a commit to hbz/lobid-resources that referenced this issue Jul 8, 2019
dr0i added a commit to hbz/lobid-resources that referenced this issue Jul 8, 2019
dr0i added a commit to hbz/lobid-resources that referenced this issue Jul 8, 2019
As the image "cloud.jpg" was loaded by javascript this had to be fixed there.

See hbz/lobid#352.
dr0i added a commit to hbz/lobid-organisations that referenced this issue Jul 9, 2019
This seems to be needed.

See hbz/lobid#352.
@acka47
Copy link
Contributor Author

acka47 commented Jul 11, 2019

We reverted the change as it meant a huge API break and looking at the logs, several clients did not follow the redirect. Thus, we should only implement this change after an announcement and time to adjust clients (if at all).
I opened #401 to at least only use https Links in the HTML.

@dr0i
Copy link
Member

dr0i commented Jul 11, 2019

Closing this issue.

@dr0i dr0i closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants