Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up prototype website with new data types #445

Closed
3 tasks done
fsteeg opened this issue Feb 22, 2021 · 11 comments · Fixed by #469
Closed
3 tasks done

Set up prototype website with new data types #445

fsteeg opened this issue Feb 22, 2021 · 11 comments · Fixed by #469

Comments

@fsteeg
Copy link
Member

fsteeg commented Feb 22, 2021

Adding projects, slide decks, and blog posts

Current state is deployed at http://stage.lobid.org/team

@fsteeg fsteeg self-assigned this Feb 22, 2021
fsteeg added a commit that referenced this issue Mar 4, 2021
fsteeg added a commit that referenced this issue Mar 4, 2021
fsteeg added a commit that referenced this issue Mar 4, 2021
@fsteeg
Copy link
Member Author

fsteeg commented Jul 9, 2021

Deployed to http://stage.lobid.org/team.

Tweaked data files used by the site are in /gatsby/lobid/static (branch is 445-data).

I'd suggest we first work on it there, and then update/move the data in /examples.

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Jul 9, 2021
@acka47
Copy link
Contributor

acka47 commented Jul 12, 2021

Thanks, @fsteeg. Below are some comments that come into mind when browsing the pages. You might directly implement the suggestions when it's easy to.

  • we need to add images for the products (e.g. logo) and maybe some simple ones for the projects ✔️ c7eeee8 & 👉 Create project logos #471
  • the tags in a publication list (e.g. http://stage.lobid.org/team/ap#!) should be linked to the repsective product/project page ✔️ 31532f4
  • the resource types (BlogPosting, PresentationDigitalDocument etc.) in a publication list should: 1. note be linked to schema.org, 2. be human-redable, 3. at best be replaced by icons for the resource types ✔️ 46f9325 (I don't think it's easy to find intuitive icons for these)
  • clicking on a publication (external resource), it should open in a new tab. Clicking on another project or product or a person should make the page open in the same tab though. ✔️ 852947e
  • sameAs links in personal profiles should be presented differenly, as logo of the respective service that links to the profile 👉 Use logos for sameAs links in team member pages #470

@fsteeg
Copy link
Member Author

fsteeg commented Jul 15, 2021

I've turned #445 (comment) into a checklist and addressed individual points inline. I've linked to the related commits for you to see the effect on the data and created new issues where I thought it makes sense.

Deployed to http://stage.lobid.org/team.

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Jul 15, 2021
@acka47
Copy link
Contributor

acka47 commented Dec 6, 2021

To Do:

  • Link project/products and to the persons that are working on it. Differ between contact point and team members

fsteeg added a commit that referenced this issue Dec 15, 2021
fsteeg added a commit that referenced this issue Dec 15, 2021
fsteeg added a commit that referenced this issue Dec 15, 2021
Use in team, project, and product pages to show members
@fsteeg
Copy link
Member Author

fsteeg commented Dec 15, 2021

Deployed to stage with new data, some tweaks, and showing members for products and projects:

http://stage.lobid.org/team

@fsteeg fsteeg linked a pull request Dec 15, 2021 that will close this issue
@acka47
Copy link
Contributor

acka47 commented Dec 16, 2021

Here are some small fixes we should implement before deploying to production:

@acka47 acka47 assigned fsteeg and unassigned acka47 Dec 16, 2021
fsteeg added a commit that referenced this issue Dec 16, 2021
fsteeg added a commit that referenced this issue Dec 17, 2021
fsteeg added a commit that referenced this issue Dec 17, 2021
@fsteeg
Copy link
Member Author

fsteeg commented Dec 17, 2021

Redeployed to stage: http://stage.lobid.org/team

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Dec 17, 2021
@acka47
Copy link
Contributor

acka47 commented Dec 17, 2021

In team pages (http://stage.lobid.org/team, http://stage.lobid.org/team/ap#!, http://stage.lobid.org/team/fs#! etc.) we should not use "lobid — Dateninfrastruktur für Bibliotheken" as heading but "Offene Infrastruktur".

This is only fixed for the team page not for person pages, see e.g. http://stage.lobid.org/team/ap#!

Otherwise, +1

@acka47 acka47 assigned fsteeg and unassigned acka47 Dec 17, 2021
fsteeg added a commit that referenced this issue Dec 17, 2021
fsteeg added a commit that referenced this issue Dec 17, 2021
@fsteeg
Copy link
Member Author

fsteeg commented Dec 17, 2021

Redeployed to stage, e.g. http://stage.lobid.org/team/ap

@fsteeg fsteeg removed their assignment Dec 17, 2021
@acka47
Copy link
Contributor

acka47 commented Dec 17, 2021

+1

dr0i added a commit that referenced this issue Dec 20, 2021
@fsteeg fsteeg closed this as completed in 2eb455c Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants