Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add NWBZarrIO.read_nwb method #225

Closed
3 tasks done
oruebel opened this issue Nov 4, 2024 · 1 comment · Fixed by #226
Closed
3 tasks done

[Feature]: Add NWBZarrIO.read_nwb method #225

oruebel opened this issue Nov 4, 2024 · 1 comment · Fixed by #226
Assignees
@oruebel
Labels
category: enhancement improvements of code or code behavior
Milestone
Next Major Releas...

Comments

@oruebel
Copy link
Contributor

oruebel commented Nov 4, 2024

What would you like to see added to HDMF-ZARR?

Add a static method NWBZarrIO.read_nwb() which would accept: 1) local path, 2) S3 path, or 3) an open Zarr store and return the corresponding NWBFile object.

This may also require update to ZarrIO.can_read to handle S3 path's properly.

Is your feature request related to a problem?

This is directly related to NeurodataWithoutBorders/pynwb#1974 with the goal to add a read_nwb convenience function.

What solution would you like?

See above

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct
@oruebel oruebel added the category: enhancement improvements of code or code behavior label Nov 4, 2024
@oruebel oruebel added this to the Next Major Release: 1.0.0 milestone Nov 4, 2024
@oruebel oruebel self-assigned this Nov 4, 2024
@oruebel
Copy link
Contributor Author

oruebel commented Nov 4, 2024

I'll take a stab at this

@oruebel oruebel mentioned this issue Nov 4, 2024
Open
3 tasks
oruebel added a commit that referenced this issue Nov 7, 2024
@oruebel
Fix #225 Add NWBZarrIO.read_nwb convenience function
cca7b20
@oruebel oruebel mentioned this issue Nov 7, 2024
Merged
10 tasks
@h-mayorquin h-mayorquin mentioned this issue Nov 7, 2024
Merged
6 tasks
oruebel added a commit that referenced this issue Nov 8, 2024
@oruebel @mavaylon1
Add NWBZarrIO.read_nwb convenience function (#226)
eae8fb5 
* Fix #225 Add NWBZarrIO.read_nwb convenience function
* Update Changelog

---------

Co-authored-by: mavaylon1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oruebel oruebel

Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Milestone
Next Major Release: 1.0.0
Development

Successfully merging a pull request may close this issue.

Add NWBZarrIO.read_nwb convenience function hdmf-dev/hdmf-zarr
1 participant
@oruebel