Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for HED specification's JSON test suite #135

Open
happy5214 opened this issue Feb 24, 2024 · 1 comment
Open

Implement support for HED specification's JSON test suite #135

happy5214 opened this issue Feb 24, 2024 · 1 comment
Labels
enhancement New feature or request tests Issues related to testcases

Comments

@happy5214
Copy link
Member

The HED specification provides a JSON-based test suite at https://github.com/hed-standard/hed-specification/tree/master/tests, which provides a set of example data (including strings, sidecars, TSV files, and combinations thereof), which should pass, and expected errors for those that should fail. This validator should eventually support validating against this test suite in an automated fashion. This would not directly affect the validator's built-in test modules.

The validation could be implemented in two stages:

  1. Simple pass-fail validation (without regard to the exact error code).
  2. Validating the actual error code.
@happy5214 happy5214 added enhancement New feature or request tests Issues related to testcases labels Feb 24, 2024
@VisLab
Copy link
Member

VisLab commented Feb 26, 2024

At this point, #1 is the most important. The hed-python GitHub actions run the tests against the spec JSON as a separate step. We could do it that way for hed-javascript. As the spec is iterated and tests are added (as happened recently with tests for the deprecatedFrom warnings), we would not expect the hed-javascript to pass right away, but this is because it requires a new feature to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Issues related to testcases
Projects
None yet
Development

No branches or pull requests

2 participants