go2avro: cannot use struct composition (kind of inheritance)

[sneko]

Hi,

I'm successfully generating Avro files from Go structure except for one kind of composed structure:

package event

type BaseEvent struct {
	EventID string `json:"eventId"`
}

type Person struct {
	BaseEvent
	Firstname string `json:"firstname"`
}

In my case the Person Avro cannot be generated I get this error:

go2avro: cannot get Avro type: cannot get type: anonymous fields not yet supported (in event.Person)

Reference:

avro/gotype.go

Lines 217 to 219 in 6d3ee10

	if f.Anonymous {
	return nil, fmt.Errorf("anonymous fields not yet supported (in %s)", t)
	}

@rogpeppe I'm not sure but for me that's not an anonymous structure since we know the structure underlying. It's just a merge of properties that needs to be done.

What do you think?

Thank you,

[rogpeppe]

Thanks for the bug report.

I'm sorry, I've used the wrong terminology in the error message there. The error message should say "embedded fields not yet supported". It shouldn't be too hard to support them, but they weren't an initial priority. This is issue #40.

I think this issue should be closed in favour of #40 - @sixstone-qq could you do that please?

[sneko]

Thank you for the answer @rogpeppe , do you have some advices to try implementing it? I'm not very familiar with Reflect manipulation but I can take a few hours to look at it.

Or do you know a similar "converter" library that already implemented this kind of thing?

[sneko]

@rogpeppe I worked on it and it seems I have something that works in complex situation.

Will make a PR in a few linked to your issue.