required tag not being honoured

[shaumux]

I created a config struct like this

type rabbitMQ struct {
	USER     string `config:"user,required"`
	PASSWORD string `config:"password,required"`
	HOST     string `config:"host"`
	PORT     string `config:"port"`
}

type dbConfig struct {
	DIALECT  string `config:"dialect,required"`
	NAME     string `config:"name,required"`
	USER     string `config:"user,required"`
	PASSWORD string `config:"password,required"`
	HOST     string `config:"host"`
	PORT     string `config:"port"`
}

type Config struct {
	DATABASES   map[string]dbConfig `config:"databases,required"`
	RABBITMQ    rabbitMQ            `config:"rabbitmq,required"`
	ENVIRONMENT string              `config:"environment"`
}

confita seems to be ignoring the required tag for all but the password field in the rabbitMQ config
The file I'm reading from is a yaml file

[yaziine]

Hi @shaumux, thank you for reporting this. Can you share us your yaml file please (without sensitive data of course 😉) ?

[shaumux]

Here's the yaml file:

databases:
  DEFAULT:
    dialect: postgres
    name: mercury
    user: shaumux
    password: shaumux
    host: localhost
    port: 5432

rabbitmq:
  user: guest
  password: guest
  host: localhost
  port: 5432

Here's the code for loading:

logger.Info("Initializing with production settings")
	once.Do(func() {
		prodDB := dbConfig{
			DIALECT: "postgres",
		}
		config = &Config{
			ENVIRONMENT: "DEVELOPMENT",
			DATABASES: map[string]dbConfig{
				"DEFAULT": devDB,
			},
		}
		var confBackends []backend.Backend
		if filePath != nil {
			if filepath.IsAbs(*filePath) != true {
				logger.Info(*filePath + " is not absolute, constructing absolute path")
				filePath, err := filepath.Abs(*filePath)
				if err != nil {
					logger.WithFields(logrus.Fields{"error": err}).Fatal("Failed to construct absolute file path with error:")
				}
				logger.WithFields(logrus.Fields{"path": filePath}).Debug("Constructed absolute filepath")
			}
			if _,err := os.Stat(*filePath); err != nil {
				if os.IsNotExist(err) {
					logger.WithFields(logrus.Fields{"ConfigFiile": *filePath, "error": err}).Warning("File does not exist")
				}
			}else{
				confBackends = append(confBackends, file.NewBackend(*filePath))
			}
		}
		confBackends = append(confBackends, env.NewBackend())
		loader := confita.NewLoader(confBackends...)
		err := loader.Load(context.Background(), config)
		if err != nil {
			logger.WithFields(logrus.Fields{"error": err}).Fatal("Failed to initialize app")
		}
})

This works even if I start removing fields from the yaml file

[yaziine]

Hey @shaumux, unfortunately, maps are not supported on Confita. It involves a lot of reflections and we do not want to go over it. Instead of having a map for each database configuration you could have a field for each? I know that is not the best solution but this might be a way to bypass the issue.

[shaumux]

The issue I'm having is not with the Database config but rather RabbitMQ config.