New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create L.WMS even in AMD? #37

Open

sheppard opened this issue Aug 25, 2016 · 0 comments

Labels

documentation needs design decison

Milestone

Member

sheppard commented Aug 25, 2016 •

edited

Loading

Currently L.WMS is only assigned when using Leaflet as a global, so you can't do this:

define(['leaflet', 'leaflet.wms'], function(L) {
    var source = L.WMS.source(...);
});

Instead you have to do this:

define(['leaflet', 'leaflet.wms'], function(L, wms) {
    var source = wms.source(...);
});

It might be less confusing (and more consistent with other plugins) to support both options when running in AMD.

sheppard added documentation needs design decison labels

sheppard modified the milestone: 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment