Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertex hash function option #35

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

rizerkrof
Copy link
Contributor

Here is my suggestion to resolve issue #33

I created option.go file to centralize all dag options.

I modify the lib such as :

  • Exported functions only receive non hashed vertex value
  • Package functions only receive hashed vertex value

The options_test.go file test all lib features on dag with vertices that contain non comparable type.

Waiting for your review :)

@rizerkrof rizerkrof force-pushed the feat/add-vertex-hash-func-option branch 2 times, most recently from e44678a to 3af12de Compare July 21, 2024 23:04
@rizerkrof rizerkrof force-pushed the feat/add-vertex-hash-func-option branch from 3af12de to 7628fd4 Compare July 22, 2024 00:19
@sebogh sebogh merged commit ced6ec2 into heimdalr:master Jul 26, 2024
0 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants