Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes 1.16 #61

Open
jdolitsky opened this issue Nov 22, 2019 · 2 comments
Open

Kubernetes 1.16 #61

jdolitsky opened this issue Nov 22, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@jdolitsky
Copy link
Collaborator

We should test against 1.16 - i tried but the deployment of the test chart fails due to the new API versions/kinds used for Deployments

Essentially we should just need to update the helm chart have the new api types, only installing them on 1.16 and vice versa?

@jdolitsky jdolitsky added the help wanted Extra attention is needed label Nov 22, 2019
@marckhouzam
Copy link
Member

I'm not sure I understood your question well but we should be able to do something like:

{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}

as taken from https://github.com/helm/helm/blob/84de17e7e5255e5033967f005d4b4c05c024317c/pkg/chartutil/create.go#L184

Although since we don't test with earlier versions than 1.14 we may be able to just change the apiVersion.

@akashshinde
Copy link
Contributor

@marckhouzam I feel we should update latest example to latest API versions, currently tests fails for all kubernetes versions which are beyond 1.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants