Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Office hours/ Booking System] design update after first draft #247

Open
tinnei opened this issue May 27, 2020 · 5 comments
Open

[Office hours/ Booking System] design update after first draft #247

tinnei opened this issue May 27, 2020 · 5 comments
Labels
enhancement New feature or request ui/ux

Comments

@tinnei
Copy link
Contributor

tinnei commented May 27, 2020

Figma design link: https://www.figma.com/file/7PSJtPUtwrdPRtXbtQFRFZ/helpwithcovid.com?node-id=1498%3A12397


Tasks to be done:
1 - Nav bar
◻️ Add "Your Office Hours" under "Your Account" in header

image

2 - [Office hour index page]
◻️ Update header button to URL
◻️ Update card layout (with new text field added in [create office hour page])

image

3 - [Create office hour page]
◻️ Add new text field "Specify what you would like to help on?"
◻️ Add section displaying current office hours (UX similar to current office hour index page)
◻️ Updated layout for create office hours

image

May have missed details in this write up. For any questions, please let us know over at #hwc-development! (Tag @tinnei / @catliu / @colinjohnson) Thank you so much!!

@cat-liu cat-liu assigned cat-liu and unassigned cat-liu May 27, 2020
@cat-liu cat-liu added enhancement New feature or request ui/ux labels May 27, 2020
@colin-johnston
Copy link
Contributor

Deleting an existing slot is super confusing. Can we put a delete action adjacent to edit on time slot hover state?

Screenshot 2020-05-29 11 03 11

@colin-johnston
Copy link
Contributor

I think it's confusing and awkward that I need to make sure to delete the event that is auto created after creating a new slot before clicking 'Create slots' if I don't want to create that additional slot. E.g.

  1. I enter info to create a new slot

Screenshot 2020-05-29 11 06 38

  1. I click '+' to generate it, and an auto generated slot appears below it

Screenshot 2020-05-29 11 06 46

  1. If I click 'Create slots' button these two are created right? But I only want the one I intentionally created. So I have to delete the second one.

Screenshot 2020-05-29 11 06 57

So...I understand how it's intended to work, but it's not how I read the UI when I try it after not looking at it for a week of so. The '+' is the action people will most likely click after entering in slot info. It will be confusing and people will create slots they didn't intend to. I suggest we have 'create slot' and 'add new slot' to the right of each inline form, and 'save slots' at the bottom instead of 'create slots'.

@colin-johnston
Copy link
Contributor

🐞 This is a bug report:

When I created a slot for 2pm on a given day it then shows up as 9pm.

Screenshot 2020-05-29 11 06 38

Screenshot 2020-05-29 11 07 09

@colin-johnston
Copy link
Contributor

There's actually no way to edit a slot, even though there's a link on the slot in the card UI:

  1. click 'edit' on slot in card

Screenshot 2020-05-29 11 18 17

  1. Land on the OH manage UI—huh?

Screenshot 2020-05-29 11 18 27

  1. Click the slot again, and no edit...

Screenshot 2020-05-29 11 18 33

I need to delete and recreate slot to change the time?

@sradu
Copy link
Contributor

sradu commented May 29, 2020

These should all be resolved. LMK if anything was missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui/ux
Projects
None yet
Development

No branches or pull requests

4 participants