Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are SVM/RF implementations available through scmap? #8

Open
CodeInTheSkies opened this issue Mar 19, 2018 · 2 comments
Open

Are SVM/RF implementations available through scmap? #8

CodeInTheSkies opened this issue Mar 19, 2018 · 2 comments

Comments

@CodeInTheSkies
Copy link

Hi there,

The help page of of scmapCluster mentions that we can potentially give the probability values for the SVM/RF classifiers through the "threshold" argument. There are also such functions for SVM and RF in the "Utils.R" script on scmap's repository here: https://github.com/hemberg-lab/scmap/blob/92566d3db92d5595eedbdf20c7f03aa2a1a053ac/R/Utils.R

So, can we actually get scmap to implement the SVM and RF methods of classifications that you actually use in the paper for any given dataset?

Just wondering, and would appreciate your answer!

Thanks!

@wikiselev
Copy link
Member

wikiselev commented Mar 19, 2018

Hi, yes, the functions that we used for SVM and RF are still in the utils. The inputs to these functions would be just expression matrices:

scmap/R/Utils.R

Line 114 in fd54f6b

support_vector_machines <- function(train, study, kern = "linear") {

Calls to these functions were used in the old versions of scmap, if you browse the github history:

if (method == "svm") {

Unfortunately, I removed them from main function at some point in the past and not sure that if you add them now, they will work (some of the functions inside these if blocks might have been also removed). However, if there is a demand of them from the users we could probably add them in the future versions, but this is not a priority at the moment.

@CodeInTheSkies
Copy link
Author

OK, thanks! For addition of these functions in the future, do count me in as one vote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants