From 7f7b31ba53cf36d7b87aa711e62da4b162bb1695 Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Wed, 10 Jan 2024 10:16:02 +0100 Subject: [PATCH] IDEMPIERE-5981 Misleading error when completing an auto-produce shipment (#2177) * IDEMPIERE-5981 Misleading error when completing an auto-produce shipment * - more robust fix --- .../base/event/delegate/AutoProduceEventDelegate.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/org.adempiere.base/src/org/adempiere/base/event/delegate/AutoProduceEventDelegate.java b/org.adempiere.base/src/org/adempiere/base/event/delegate/AutoProduceEventDelegate.java index 1307db053c..e6b454b5ff 100644 --- a/org.adempiere.base/src/org/adempiere/base/event/delegate/AutoProduceEventDelegate.java +++ b/org.adempiere.base/src/org/adempiere/base/event/delegate/AutoProduceEventDelegate.java @@ -240,7 +240,14 @@ private String createProduction(MInOut mInOut, MInOutLine mInOutLine, BigDecimal //complete the production ProcessInfo pi = MWorkflow.runDocumentActionWorkflow(production, "CO"); if (pi.isError()) { - return production.getProcessMsg(); + StringBuilder msgError = new StringBuilder(); + if (!Util.isEmpty(pi.getSummary())) + msgError.append(pi.getSummary()); + if (!Util.isEmpty(production.getProcessMsg())) + msgError.append(" - " ).append(production.getProcessMsg()); + if (msgError.length() == 0) // unlikely to arrive here, but we need to ensure that issues is raised + msgError.append("Error completing auto-produce production"); + return msgError.toString(); } return null; }