Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tspan mutable for Boris #158

Open
henry2004y opened this issue Mar 20, 2024 · 0 comments
Open

Make tspan mutable for Boris #158

henry2004y opened this issue Mar 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@henry2004y
Copy link
Owner

henry2004y commented Mar 20, 2024 •
edited
Loading

Our current implementation for TraceProblem only allows changing the initial conditions, and it only shows up in sol.u[1], but not sol.prob.u0. This is because

  • The newly generated prob_new does not replace prob
  • Time steps are calculated in _prepare, which is the same for all particles.

Take a look here:

https://github.com/SciML/SciMLBase.jl/blob/3746cda651df79e3d9d7af9aa71e78bd9ecd8ecd/src/ensemble/basic_ensemble_solve.jl#L122-L234

Maybe this is useful too: https://julialang.org/blog/2022/08/julia-1.8-highlights/#const_on_fields_in_mutable_structs
@henry2004y henry2004y added the enhancement New feature or request label Mar 20, 2024
@henry2004y henry2004y mentioned this issue Mar 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henry2004y