Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

我对代码做了些修改 #44

Open
nlh1996 opened this issue Jun 13, 2019 · 4 comments
Open

我对代码做了些修改 #44

nlh1996 opened this issue Jun 13, 2019 · 4 comments

Comments

@nlh1996
Copy link

nlh1996 commented Jun 13, 2019

89ip.go err处理有问题,有时会导致空指针。

if resp.StatusCode != 200 {
//	clog.Warn(err.Error())
  return
}

xicidl.go 请求有问题,我重写了。

详见 https://github.com/nlh1996/gopa/blob/master/proxy/xicidl.go

@henson
Copy link
Owner

henson commented Jun 13, 2019

欢迎pull request

@sndnvaps
Copy link
Contributor

89ip.go err处理有问题,有时会导致空指针。

if resp.StatusCode != 200 {
//	clog.Warn(err.Error())
  return
}

xicidl.go 请求有问题,我重写了。

详见 https://github.com/nlh1996/gopa/blob/master/proxy/xicidl.go

这个是,判断返回值为200,即ok
如果不是200,即操作有问题,clog.Warn(err.Error())打印出错的信息

@nlh1996
Copy link
Author

nlh1996 commented Jun 15, 2019

请结合原代码的情境看,此处err可能是nil,调用Error方法会引发异常。

@sndnvaps
Copy link
Contributor

请结合原代码的情境看,此处err可能是nil,调用Error方法会引发异常。

有这个可能性。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants