Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for type aliases in Dart #907

Open
DanielKamkha opened this issue May 20, 2021 · 1 comment · May be fixed by #1163
Open

Add full support for type aliases in Dart #907

DanielKamkha opened this issue May 20, 2021 · 1 comment · May be fixed by #1163
Labels
dart enhancement New feature or request

Comments

@DanielKamkha
Copy link
Contributor

Dart 2.13 adds support for type aliases. So Gluecodium needs to start generating those too (currently they are just resolved and replaced by the target type, similar to Java). However, the release of this feature will probably be delayed until HERE internal users of Gluecodium are ready to have Dart 2.13 as a minimum version in pubspec.yaml.

@DanielKamkha DanielKamkha added enhancement New feature or request dart labels May 20, 2021
@DanielKamkha DanielKamkha self-assigned this Jun 17, 2021
DanielKamkha added a commit that referenced this issue Jun 17, 2021
Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
@DanielKamkha
Copy link
Contributor Author

The results are shelved in the dart-type-aliases branch. Using the code with type aliases requires minimum version of Dart set to 2.13.0 in pubspec.yaml, so not releasing this yet until HERE-internal users of Gluecodium are ready to bump the minimum version.

@DanielKamkha DanielKamkha removed their assignment Jul 16, 2021
DanielKamkha added a commit that referenced this issue Sep 10, 2021
Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Sep 30, 2021
Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Nov 5, 2021
TODO: describe
TODO: split
TODO: changelog

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Nov 8, 2021
TODO: describe
TODO: split
TODO: changelog

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Nov 8, 2021
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Nov 8, 2021
@DanielKamkha DanielKamkha linked a pull request Nov 9, 2021 that will close this issue
DanielKamkha added a commit that referenced this issue Nov 10, 2021
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Nov 10, 2021
DanielKamkha added a commit that referenced this issue Nov 12, 2021
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Nov 12, 2021
DanielKamkha added a commit that referenced this issue Jan 5, 2022
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Jan 5, 2022
DanielKamkha added a commit that referenced this issue Feb 10, 2022
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Feb 10, 2022
DanielKamkha added a commit that referenced this issue Jul 5, 2022
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Jul 5, 2022
DanielKamkha added a commit that referenced this issue Jul 5, 2022
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Jul 5, 2022
DanielKamkha added a commit that referenced this issue Jul 5, 2022
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Jul 5, 2022
DanielKamkha added a commit that referenced this issue Aug 3, 2022
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Aug 3, 2022
DanielKamkha added a commit that referenced this issue Aug 18, 2022
Added dedicated DartTypeAlias template, as type aliases (typedefs) are now
supported in Dart language (since Dart version 2.13). Updated other Dart
tempates and resolvers to treat type aliases as a normal type, instead of
skipping it through to the target type.

Added/updated related smoke and functional tests.

Unrelated smoke tests are updated in a separate commit.

Resolves: #907
Signed-off-by: Daniel Kamkha <[email protected]>
DanielKamkha added a commit that referenced this issue Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant