build(deps): Bump arm-gic from 0.1.2 to 0.2.1 #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/cargo/arm-gic-0.2.1
branch
3 times, most recently
from
1b8b024 to
cc7e830
Compare
stlankes
force-pushed
the
dependabot/cargo/arm-gic-0.2.1
branch
from
56ff516 to
6380f69
Compare
fstracke
approved these changes
Feb 25, 2025
| gicd_address.as_mut_ptr(), | ||
| gicc_address.as_mut_ptr(), | ||
| 1, | ||
| 0x20000, |
There was a problem hiding this comment.
I think it is better to set the stride as 0 in the default case, as it represents the offset to the next redistributor interface. It shouldn't change the behaviour, however.
| @@ -320,22 +328,22 @@ pub(crate) fn init() { | |||
| } else { | |||
| panic!("Invalid interrupt type"); | |||
| }; | |||
| gic.set_interrupt_priority(timer_irqid, 0x00); | |||
| gic.set_interrupt_priority(timer_irqid, Some(0), 0x00); | |||
There was a problem hiding this comment.
This hard-defaults core 0 as the interrupt handling core. Will probably work, but disables all other cores from recieving PPIs in an smp environment.
There was a problem hiding this comment.
Yes, I thought that also the current solution use core 0 and in the future we have to find a better solution
Bumps [arm-gic](https://github.com/google/arm-gic) from 0.1.2 to 0.2.1. - [Release notes](https://github.com/google/arm-gic/releases) - [Changelog](https://github.com/google/arm-gic/blob/main/CHANGELOG.md) - [Commits](google/arm-gic@0.1.2...0.2.1) --- updated-dependencies: - dependency-name: arm-gic dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
- Initialize gic to support 1 processor
stlankes
force-pushed
the
dependabot/cargo/arm-gic-0.2.1
branch
from
66ac0de to
ebd9f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps arm-gic from 0.1.2 to 0.2.1.
Release notes
Sourced from arm-gic's releases.
Changelog
Sourced from arm-gic's changelog.
Commits
4a0cc95Prepare for 0.2.1 release.8a566c0Fix docs.rs build.d2a582cRemove a keyword from Cargo.toml.dcc7e79Prepare for 0.2.0 release.0d1c193Merge pull request #37 from google/typer01b1316Add Typer wrapper type for GICv2 too.2868e46Fix clippy lint warnings.db52249Merge pull request #36 from google/multicoreb46d2b3Add to changelog.d23f49dPass base address and stride for redistributors.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)