Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libvsync tests #618

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Add libvsync tests #618

merged 3 commits into from
Feb 16, 2024

Conversation

hernanponcedeleon
Copy link
Owner

No description provided.

@ThomasHaas
Copy link
Collaborator

I think you should add links to the original source code files to make it easier to see what we are actually testing (reading the LLVM is hard :P).

ThomasHaas
ThomasHaas approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@ThomasHaas ThomasHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Btw. the llvm code has some inline assembly. Not sure what it exactly does (compiler barrier with extra flags?)

@hernanponcedeleon
Copy link
Owner Author

hernanponcedeleon commented Feb 16, 2024 •
edited
Loading

Yes, just compiler barriers (i.e. nops) required to "match" vmm with c11 builtins, e.g. like this

@hernanponcedeleon hernanponcedeleon merged commit 080770f into development Feb 16, 2024
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the libvsync branch February 16, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasHaas ThomasHaas ThomasHaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hernanponcedeleon @ThomasHaas @hernan-poncedeleon